[ https://issues.apache.org/jira/browse/SOLR-6576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14155103#comment-14155103 ]
Hoss Man commented on SOLR-6576: -------------------------------- bq. So in my head I would think the method for the current functionality would mimic the "set" capability ... and should be named appropriately. I don't disagree with you, it's just the missfortune of how the API evolved w/o people giving a more critical eye to what those methods were named. bq. Also, SolrParams.wrapAppended(SolrParams) is deprecated so that isn't very re-assuring to use. Uh? ... no it's not what makes you say that? https://lucene.apache.org/solr/4_10_0/solr-solrj/org/apache/solr/common/params/SolrParams.html#wrapAppended%28org.apache.solr.common.params.SolrParams,%20org.apache.solr.common.params.SolrParams%29 > ModifiableSolrParams#add(SolrParams) is performing a set operation instead of > an add > ------------------------------------------------------------------------------------ > > Key: SOLR-6576 > URL: https://issues.apache.org/jira/browse/SOLR-6576 > Project: Solr > Issue Type: Bug > Reporter: Steve Davids > Fix For: 5.0, Trunk > > Attachments: SOLR-6576.patch > > > Came across this bug by attempting to append multiple ModifiableSolrParam > objects together but found the last one was clobbering the previously set > values. The add operation should append the values to the previously defined > values, not perform a set operation. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org