[
https://issues.apache.org/jira/browse/LUCENE-5992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14160398#comment-14160398
]
Uwe Schindler edited comment on LUCENE-5992 at 10/6/14 3:37 PM:
----------------------------------------------------------------
The documentation of Version#write is now incorrect. It still says "vint". Also
this comment is now obsolete (I think): "// NOTE: do not change this format!
If you do, you must fix all callers of this API, everywhere in the world to
handle the format change:"
In fact we can change it now, because of the marker byte.
I had another idea: the first byte could also be the "number of version
components" (like when writing a string). If we write version with 3
components, it is 3, 4 otherwise. Then we have full flexibility, too.
was (Author: thetaphi):
The documentation of Version#write is now incorrect. It still says "vint".
> Version should not be encoded as a String in the index
> ------------------------------------------------------
>
> Key: LUCENE-5992
> URL: https://issues.apache.org/jira/browse/LUCENE-5992
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Michael McCandless
> Assignee: Michael McCandless
> Fix For: 5.0, Trunk
>
> Attachments: LUCENE-5992.patch, LUCENE-5992.patch
>
>
> The version is really "just" 3 (maybe 4) ints under-the-hood, but today we
> write it as a String which then requires spooky string tokenization/parsing
> when we open the index. I think it should be encoded directly as ints.
> In LUCENE-5952 I had tried to make this change, but it was controversial, and
> got booted.
> Then in LUCENE-5969, I tried again, but that issue has morphed (nicely!) into
> fixing all sorts of things *except* these three ints.
> Maybe 3rd time's a charm ;)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
