[ 
https://issues.apache.org/jira/browse/SOLR-6326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14162386#comment-14162386
 ] 

Peter Keegan commented on SOLR-6326:
------------------------------------

After revisiting this issue again, I noticed that the EFF reload was occuring 
in Solr 4.6 on a newSearcher listener, but not in 4.9, because of this change 
to SolrCore.openNewSearcher:

        if (newReader == null) { // the underlying index has not changed at all

          if (realtime) {
            // if this is a request for a realtime searcher, just return the 
same searcher
            newestSearcher.incref();
            return newestSearcher;

          } else if (newestSearcher.get().isCachingEnabled() && 
newestSearcher.get().getSchema() == getLatestSchema()) {
            // absolutely nothing has changed, can use the same searcher
            // but log a message about it to minimize confusion

            newestSearcher.incref();
            log.info("SolrIndexSearcher has not changed - not re-opening: " + 
newestSearcher.get().getName());
            return newestSearcher;

          } // ELSE: open a new searcher against the old reader...
          currentReader.incRef();
          newReader = currentReader;
        }

So maybe this needs to be modified to check to see if there are any new EFF 
files to load?



> ExternalFileFieldReloader and commits
> -------------------------------------
>
>                 Key: SOLR-6326
>                 URL: https://issues.apache.org/jira/browse/SOLR-6326
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Peter Keegan
>              Labels: difficulty-medium, externalfilefield, impact-medium
>
> When there are multiple 'external file field' files available, Solr will 
> reload the last one (lexicographically) with a commit, but only if changes 
> were made to the index. Otherwise, it skips the reload and logs: "No 
> uncommitted changes. Skipping IW.commit." 
> IndexWriter.hasUncommittedChanges() returns false, but new external files 
> should be reloaded with commits.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to