[
https://issues.apache.org/jira/browse/SOLR-6307?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14172262#comment-14172262
]
Anurag Sharma commented on SOLR-6307:
-------------------------------------
Thanks a lot for reviewing and refactoring it.
Introducing the toNativeType() at FieldType is good. Only one thing I see is
missed in class TrieIntField when overriding toNativeType. It is not parsing
Double before Float TrieIntField. The intention of doing it was to find if
Double can be extracted before Float. Rest is good.
Snippet from earlier patch
+ // when Double value passed as a String
+ if(!removed && nonIntegerFormat)
+ removed = original.remove((new
Double(Double.parseDouble(object.toString()))).intValue());
+ // when Float value passed as a String
+ if(!removed && nonIntegerFormat)
+ removed = original.remove(new
Float(Float.parseFloat(object.toString())).intValue());
> Atomic update remove does not work for int array or date array
> --------------------------------------------------------------
>
> Key: SOLR-6307
> URL: https://issues.apache.org/jira/browse/SOLR-6307
> Project: Solr
> Issue Type: Bug
> Components: update
> Affects Versions: 4.9
> Reporter: Kun Xi
> Assignee: Noble Paul
> Labels: atomic, difficulty-medium, impact-medium
> Attachments: SOLR-6307.patch, SOLR-6307.patch, SOLR-6307.patch,
> unitTests-6307.txt
>
>
> Try to remove an element in the string array with curl:
> {code}
> curl http://localhost:8080/update\?commit\=true -H
> 'Content-type:application/json' -d '[{ "attr_birth_year_is": { "remove":
> [1960]}, "id": 1098}]'
> curl http://localhost:8080/update\?commit\=true -H
> 'Content-type:application/json' -d '[{"reserved_on_dates_dts": {"remove":
> ["2014-02-12T12:00:00Z", "2014-07-16T12:00:00Z", "2014-02-15T12:00:00Z",
> "2014-02-21T12:00:00Z"]}, "id": 1098}]'
> {code}
> Neither of them works.
> The set and add operation for int array works.
> The set, remove, and add operation for string array works
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
