[ 
https://issues.apache.org/jira/browse/SOLR-6351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Hoss Man updated SOLR-6351:
---------------------------
    Attachment: SOLR-6351.patch

small bits of progress on the patch review...

* PivotField
** fixed backcompt with constructor
** simplified write method & fixed NPE risk + indenting

* DistributedFacetPivotLargeTest
** refactored query + assertFieldStats into "doTestDeepPivotStats"
*** only called once, and wasn't general in anyway - only usable for checking 
one specific query
** made the epsilon used in assertEqual(double) a tiny float (0.1E-7) instead 
of a large float, so we don't overlook any bugs

* DistributedFacetPivotSmallTest
** simplified ComparablePivotField
*** it isn't used with stat assertions, and didn't check stats when it was 
used, so it doesn't need to know about stats in it's constructor
** refactored query + assertFieldStats into "doTestDeepPivotStats"
*** only called once, and wasn't general in anyway - only usable for checking 
one specific query
*** simplified params (no need to muck with setDistributedParams
** made the epsilon used in assertEqual(double) a tiny float (0.1E-7) instead 
of a large float, so we don't overlook any bugs

* DistributedFacetPivotLongTailTest
** did the match to fill in the expected values of the remaining nocommits
** made the epsilon used in assertEqual(double) a tiny float (0.1E-7) instead 
of a large float, so we don't overlook any bugs


> Let Stats Hang off of Pivots (via 'tag')
> ----------------------------------------
>
>                 Key: SOLR-6351
>                 URL: https://issues.apache.org/jira/browse/SOLR-6351
>             Project: Solr
>          Issue Type: Sub-task
>            Reporter: Hoss Man
>         Attachments: SOLR-6351.patch, SOLR-6351.patch, SOLR-6351.patch, 
> SOLR-6351.patch, SOLR-6351.patch, SOLR-6351.patch, SOLR-6351.patch, 
> SOLR-6351.patch, SOLR-6351.patch, SOLR-6351.patch
>
>
> he goal here is basically flip the notion of "stats.facet" on it's head, so 
> that instead of asking the stats component to also do some faceting 
> (something that's never worked well with the variety of field types and has 
> never worked in distributed mode) we instead ask the PivotFacet code to 
> compute some stats X for each leaf in a pivot.  We'll do this with the 
> existing {{stats.field}} params, but we'll leverage the {{tag}} local param 
> of the {{stats.field}} instances to be able to associate which stats we want 
> hanging off of which {{facet.pivot}}
> Example...
> {noformat}
> facet.pivot={!stats=s1}category,manufacturer
> stats.field={!key=avg_price tag=s1 mean=true}price
> stats.field={!tag=s1 min=true max=true}user_rating
> {noformat}
> ...with the request above, in addition to computing the min/max user_rating 
> and mean price (labeled "avg_price") over the entire result set, the 
> PivotFacet component will also include those stats for every node of the tree 
> it builds up when generating a pivot of the fields "category,manufacturer"



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to