[
https://issues.apache.org/jira/browse/SOLR-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Anurag Sharma updated SOLR-6572:
--------------------------------
Attachment: SOLR-6572.unittest
SOLR-6572.patch
I think this issue could have been easily reproduced in unit test. In
DOMUtilTest some how space, new line, tab unit tests were missing before and
after node value. This infers that other elements in solrconfig.xml will also
have issues. One sample I tried is in <infoStream> under <indexConfig> tag. eg.
If I give like "infoStream" value is picked as true and works fine.
{code}
<indexConfig>
:
<infoStream>true</infoStream>
</indexConfig>
{code}
on the other hand If I give like "infoStream" value is picked as "false" and
miss to read it as "true"
{code}
<indexConfig>
:
<infoStream>true
</infoStream>
</indexConfig>
{code}
Fix with unit tests and unit test run report is attached.
> lineshift in solrconfig.xml is not supported
> --------------------------------------------
>
> Key: SOLR-6572
> URL: https://issues.apache.org/jira/browse/SOLR-6572
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.8.1
> Reporter: Fredrik Rodland
> Labels: difficulty-easy, impact-low, solrconfig.xml
> Attachments: SOLR-6572.patch, SOLR-6572.unittest
>
>
> This has been a problem for a long time, and is still a problem at least for
> SOLR 4.8.1.
> If lineshifts are introduced in some elements in solrconfig.xml SOLR fails to
> pick up on the values.
> example:
> ok:
> {code}
> <requestHandler name="/replication" class="solr.ReplicationHandler"
> enable="${enable.replication:false}">
> <lst name="slave">
> <str
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}</str>
> {code}
> not ok:
> {code}
> <requestHandler name="/replication" class="solr.ReplicationHandler"
> enable="${enable.replication:false}">
> <lst name="slave">
> <str
> name="masterUrl">${solr.master.url:http://solr-admin1.finn.no:12910/solr/front-static/replication}
> </str>
> {code}
> Other example:
> ok:
> {code}
> <str
> name="shards">localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr</str>
> {code}
> not ok:
> {code}
> <str name="shards">
> localhost:12100/solr,localhost:12200/solr,localhost:12300/solr,localhost:12400/solr,localhost:12500/solr,localhost:12530/solr
> </str>
> {code}
> IDEs and people tend to introduce lineshifts in xml-files to make them
> prettyer. SOLR should really not be affected by this.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
