This constant is gone as of 5.x (LUCENE-5900): good riddance ;)
Mike McCandless http://blog.mikemccandless.com On Sun, Oct 26, 2014 at 5:30 AM, Uwe Schindler <[email protected]> wrote: > I think we should do this also in 5.x and trunk. I am not sure if the > problem exists there, too, but that would make it easier. > > > > There is only one reason why you _*could*_ make those versions explicit: > If you want to prevent users mixing the test framework with an incorrect > version of Lucene (e.g. use test-franework version 4.10.0 with Lucene > 4.10.2). But we have no check for this, so this is theoretical… > > > > Uwe > > > > ----- > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: [email protected] > > > > *From:* Michael McCandless [mailto:[email protected]] > *Sent:* Sunday, October 26, 2014 10:24 AM > *To:* Lucene/Solr dev > > *Subject:* Re: [VOTE] Release 4.10.2 RC0 > > > > +1, I'll just do that. > > > > Mike McCandless > > http://blog.mikemccandless.com > > > > On Sun, Oct 26, 2014 at 5:21 AM, Uwe Schindler <[email protected]> wrote: > > Why not set the constant in LTC to LUCENE_LATEST? It is no longer an enum, > so there is no need to set it explicit. Version.LUCENE_LATEST explicitely > points to latest. > > > > Uwe > > > > ----- > > Uwe Schindler > > H.-H.-Meier-Allee 63, D-28213 Bremen > > http://www.thetaphi.de > > eMail: [email protected] > > > > *From:* Michael McCandless [mailto:[email protected]] > *Sent:* Sunday, October 26, 2014 9:38 AM > *To:* Lucene/Solr dev; Simon Willnauer > *Subject:* Re: [VOTE] Release 4.10.2 RC0 > > > > Argh. Why does no Lucene test fail ... > > > > I'll add a failing test, fix the constant, respin. > > > > Mike McCandless > > http://blog.mikemccandless.com > > > > On Sun, Oct 26, 2014 at 4:32 AM, Simon Willnauer < > [email protected]> wrote: > > I think we need to respin here - I upgraded ES and I got some failures > since the > > > > LuceneTestCase#TEST_VERSION_CURRENT is still 4.10.1 > > > > see: > > > > > http://svn.apache.org/viewvc/lucene/dev/branches/lucene_solr_4_10/lucene/test-framework/src/java/org/apache/lucene/util/LuceneTestCase.java > > > > i am not sure if this has impact on anything but it's definitely wrong no? > I think there should be a test in lucene that checks if this version points > to `Versoin.LATEST`? > > > > simon > > > > On Sat, Oct 25, 2014 at 11:35 PM, Anshum Gupta <[email protected]> > wrote: > > +1 > > > > SUCCESS! [1:05:35.187369] > > > > On Fri, Oct 24, 2014 at 9:53 AM, Michael McCandless < > [email protected]> wrote: > > Artifacts: > http://people.apache.org/~mikemccand/staging_area/lucene-solr-4.10.2-RC0-rev1634084/ > > Smoke tester: python3 -u dev-tools/scripts/smokeTestRelease.py > > http://people.apache.org/~mikemccand/staging_area/lucene-solr-4.10.2-RC0-rev1634084 > 1634084 4.10.2 /tmp/smoke4102 True > > SUCCESS! [0:29:20.274057] > > Here's my +1 > > Mike McCandless > > http://blog.mikemccandless.com > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > > > > > -- > > *Anshum Gupta* > > about.me/anshumgupta > > > > > > > > >
