David Smiley created LUCENE-6033:
------------------------------------

             Summary: Add CachingTokenFilter.isCached and switch LinkedList to 
ArrayList
                 Key: LUCENE-6033
                 URL: https://issues.apache.org/jira/browse/LUCENE-6033
             Project: Lucene - Core
          Issue Type: Improvement
            Reporter: David Smiley
            Assignee: David Smiley
             Fix For: 5.0


CachingTokenFilter could use a simple boolean isCached() method implemented 
as-such:
{code:java}
  /** If the underlying token stream was consumed and cached */
  public boolean isCached() {
    return cache != null;
  }
{code}
It's useful for the highlighting code to remove its wrapping of 
CachingTokenFilter if after handing-off to parts of its framework it turns out 
that it wasn't used.

Furthermore, use an ArrayList, not a LinkedList.  ArrayList is leaner when the 
token count is high, and this class doesn't manipulate the list in a way that 
might favor LL.

A separate patch will come that actually uses this method.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to