[ https://issues.apache.org/jira/browse/SOLR-6533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14191199#comment-14191199 ]
Tomás Fernández Löbbe commented on SOLR-6533: --------------------------------------------- What about my previous comment? I think users should be able to enable/disable this feature. A couple of minor things: I saw some {{e.printStackTrace();//todo handle Exception}} that should probably be fixed before committing Also, there are many places where generics are used without parameters. I know there are lots of places in the current code when this is happening, but I think new code should always use parametrized generics when possible. There is some commented out code, should that be removed instead? > Support editing common solrconfig.xml values > -------------------------------------------- > > Key: SOLR-6533 > URL: https://issues.apache.org/jira/browse/SOLR-6533 > Project: Solr > Issue Type: Sub-task > Reporter: Noble Paul > Attachments: SOLR-6533.patch, SOLR-6533.patch, SOLR-6533.patch, > SOLR-6533.patch, SOLR-6533.patch, SOLR-6533.patch, SOLR-6533.patch > > > There are a bunch of properties in solrconfig.xml which users want to edit. > We will attack them first > These properties will be persisted to a separate file called config.json (or > whatever file). Instead of saving in the same format we will have well known > properties which users can directly edit > {code} > updateHandler.autoCommit.maxDocs > query.filterCache.initialSize > {code} > The api will be modeled around the bulk schema API > {code:javascript} > curl http://localhost:8983/solr/collection1/config -H > 'Content-type:application/json' -d '{ > "set-property" : {"updateHandler.autoCommit.maxDocs":5}, > "unset-property": "updateHandler.autoCommit.maxDocs" > }' > {code} > {code:javascript} > //or use this to set ${mypropname} values > curl http://localhost:8983/solr/collection1/config -H > 'Content-type:application/json' -d '{ > "set-user-property" : {"mypropname":"my_prop_val"}, > "unset-user-property":{"mypropname"} > }' > {code} > The values stored in the config.json will always take precedence and will be > applied after loading solrconfig.xml. > An http GET on /config path will give the real config that is applied . > An http GET of/config/overlay gives out the content of the configOverlay.json > /config/<component-name> gives only the fchild of the same name from /config -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org