[ 
https://issues.apache.org/jira/browse/LUCENE-2834?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Uwe Schindler updated LUCENE-2834:
----------------------------------

    Attachment: LUCENE-2834.patch

Here my patch. With the System.out in FSDir.getLockID I checked when this 
method is called now. I changed the code in FSDir.setLockFactory() a little bit 
to not always call getLockId() and then lazy init the MessageDigest. Now its 
only called two times during the whole test run: once in TestIndexWriter 
(because there is some test with a lock file in foreign dir) and once in the 
LockFactory test (same reason). All other tests never call getLockID() useless.

I don't like it to kill the PKCS thread, I just added it to the exclusion list 
in LuceneTestCase (using a regex on SunPKCS12). There may be other platform 
doing the same (as the SunPKCS provider uses for performance and consistency 
native algorithm routines from the underlying operating system, like the root 
certificates).

> don't spawn thread statically in FSDirectory on Mac OS X
> --------------------------------------------------------
>
>                 Key: LUCENE-2834
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2834
>             Project: Lucene - Java
>          Issue Type: Bug
>            Reporter: Robert Muir
>             Fix For: 3.1, 4.0
>
>         Attachments: LUCENE-2834.patch, LUCENE-2834.patch
>
>
> on the Mac, creating the digester starts up a PKCS11 thread.
> I do not think threads should be created statically (I have this same issue 
> with TimeLimitedCollector and also FilterManager).
> Uwe discussed removing this md5 digester, I don't care if we remove it or 
> not, just as long as it doesn't create a thread,
> and just as long as it doesn't use the system default locale.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to