[ 
https://issues.apache.org/jira/browse/SOLR-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12975510#action_12975510
 ] 

Robert Muir commented on SOLR-2276:
-----------------------------------

bq. Seems ColognePhonetic will be supported in Apache Commons Codec 1.4.1.

Thanks for your patch Marc. Has there been any discussion on a tentative 
release date for 1.4.1?
When this happens I'll be happy to add it.

{quote}
Besides, do you think it is a good idea to allow a fully qualified class name 
as "encoder" in PhoneticFilterFactory? Extending solr by a custom phonetic 
filter could be much easier for developers.
{quote}

I think the reason its not done with reflection might be historical, before all 
tokenstreams were reused?
But I still think its a good idea to avoid reflection when possible, so I think 
we should keep the statically built map.

However, if you supply a string thats not in this map, I don't think it would 
hurt to try to reflect the name
before throwing an exception, as in this case you would only get an exception 
anyway.


> Support for cologne phonetic
> ----------------------------
>
>                 Key: SOLR-2276
>                 URL: https://issues.apache.org/jira/browse/SOLR-2276
>             Project: Solr
>          Issue Type: Improvement
>          Components: Schema and Analysis
>    Affects Versions: 1.4.1
>         Environment: Apache Commons Codec 1.5
>            Reporter: Marc Pompl
>             Fix For: 4.0
>
>         Attachments: ColognePhonetic-patch.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> As soon as Apache Commons Codec 1.5 is released, support new encoder 
> "ColognePhonetic" please.
> See JIRA for CODEC-106.
> It is fundamental for phonetic searches if you are indexing german names. 
> Other indexers are optimizied for english (words).

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to