[ 
https://issues.apache.org/jira/browse/SOLR-6324?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14228011#comment-14228011
 ] 

Shalin Shekhar Mangar commented on SOLR-6324:
---------------------------------------------

This patch doesn't set any timeouts for updates? I've found that many people 
don't know about the update shard handler timeouts because it's not mentioned 
in the example solr.xml by default in contrast to the search timeouts. 

Large timeouts are equally useless as no timeouts for heavy users but at least 
by having both update/search timeouts in solr.xml, people might pay more 
attention and actually set some sane values.

+1 to the change. I swear I had opened an issue for the same thing a month back 
but I can't find it now.

> Set finite default timeouts for select and update
> -------------------------------------------------
>
>                 Key: SOLR-6324
>                 URL: https://issues.apache.org/jira/browse/SOLR-6324
>             Project: Solr
>          Issue Type: Improvement
>          Components: search, update
>            Reporter: Ramkumar Aiyengar
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, Trunk
>
>
> Currently {{HttpShardHandlerFactory}} and {{UpdateShardHandler}} default to 
> infinite timeouts for socket connection and read. This can lead to 
> undesirable behaviour, for example, if a machine crashes, then searches in 
> progress will wait forever for a result to come back and end up using threads 
> which will only get terminated at shutdown.
> We should have some finite default, however conservative it might be. These 
> parameters are already configurable, so for expert uses, they can be 
> increased if necessary anyway.
> Will attach a patch to set connection timeout to 60s and read timeout to 
> 600s, but I am not too concerned about the actual value as long as there is 
> one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to