: assumeFalse("this test can't run on Windows", Constants.WINDOWS);
:
: MockDirectoryWrapper dir = newMockDirectory();
: + if (TestUtil.isWindowsFS(dir)) {
: + dir.close();
: + assumeFalse("this test can't run on Windows", true);
: + }
this specific assume msg seems like a bad idea.
ie: a new dev, who doesn't know about the FS mocking behavior of
the test cases, who tries to run lucene tests on a mac and sees a
test skipped with the message "this test can't run on Windows" i'm going
to be confused as hell.
I also have to wonder: rather then just a straight assumeFalse, wouldn't
it be better in this case to just upwrap the mock "windowsfs" and just
explicitly use the "real" fs for this particular test? (in hte interest of
maximizing test coverage)
-Hoss
http://www.lucidworks.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
