[ 
https://issues.apache.org/jira/browse/LUCENE-6084?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14230633#comment-14230633
 ] 

Hoss Man commented on LUCENE-6084:
----------------------------------

I was about to commit this (didn't see you on IRC) but i'll defer to you as the 
expert...

{noformat}
Index: 
lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene40/Lucene40CompoundWriter.java
===================================================================
--- 
lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene40/Lucene40CompoundWriter.java
       (revision 1642776)
+++ 
lucene/backward-codecs/src/java/org/apache/lucene/codecs/lucene40/Lucene40CompoundWriter.java
       (working copy)
@@ -306,7 +306,7 @@
 
     DirectCFSIndexOutput(IndexOutput delegate, FileEntry entry,
         boolean isSeparate) {
-      super();
+      
super("DirectCFSIndexOutput("+delegate.toString()+",entry=\""+entry.toString()+"\",isSeparate=\""+isSeparate+")");
       this.delegate = delegate;
       this.entry = entry;
       entry.offset = offset = delegate.getFilePointer();
{noformat}

> Add reasonable IndexOutput.toString
> -----------------------------------
>
>                 Key: LUCENE-6084
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6084
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>            Priority: Minor
>             Fix For: 5.0, Trunk
>
>         Attachments: LUCENE-6084.patch, LUCENE-6084.patch
>
>
> In LUCENE-3539 we fixed IndexInput.toString to always include the 
> resourceDescription.
> I think we should do the same for IndexOutput?
> I don't think Lucene currently uses/relies on IndexOutput.toString, but e.g. 
> at least Elasticsearch does, and likely others, so I think it can only help 
> if you can see which path is open by this IndexOutput.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to