[
https://issues.apache.org/jira/browse/LUCENE-6115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248133#comment-14248133
]
Robert Muir commented on LUCENE-6115:
-------------------------------------
At a glance the patch looks great. About testing, does/can our
BaseXXXStoredFieldsTest exercise merging in the different ways?
Stored fields are easy to write without flushing and merging. we should be able
to do things like call addIndexes(bogusWrapper) for now and really exercise the
different cases.
> Add getMergeInstance to CompressingStoredFieldsReader
> -----------------------------------------------------
>
> Key: LUCENE-6115
> URL: https://issues.apache.org/jira/browse/LUCENE-6115
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Adrien Grand
> Assignee: Adrien Grand
> Priority: Minor
> Attachments: LUCENE-6115.patch
>
>
> CompressingStoredFieldsReader is currently terrible at merging with different
> codecs or wrapped readers since it does not keep state. So if you want to get
> 5 documents that come from the same block, it means that you will have to
> decode the block header and decompress 5 times. It has some optimizations so
> that if you want to get the 2nd doc of the block then it will stop
> decompressing soon after the 2nd document, but it doesn't help much with
> merging since we want all documents.
> We should implement getMergeInstance and have a different behaviour when
> merging by decompressing everything up-front and then reusing for all
> documents of the block.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
