[ https://issues.apache.org/jira/browse/SOLR-6813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14248200#comment-14248200 ]
Joel Bernstein edited comment on SOLR-6813 at 12/16/14 12:37 PM: ----------------------------------------------------------------- The test will fail when the number of collapsed groups returned by the query is larger then the page size. For example with start=1 and rows=1 the controlRsp will have one expanded group, while the rsp will have multiple expanded groups. With default page size of 10, both the controlRsp and rsp will have four expanded groups so the tests pass. We can solve the test failures easily with a change to handleResults to remove groups that are not in the final docList. The distributed deep paging problem will continue to exist. The only way I see to resolve that problem is with the two pass model. distrib.singlePass is not the most efficient approach for every situation, so we can pick and choose when to apply it. [~shalinmangar], how does distrib.singlePass work with standard grouping? I suspect grouping still does multi-pass because it has a different distributed flow. was (Author: joel.bernstein): The test will fail when the number of collapsed groups returned by the query is larger then the page size. For example with start=1 and rows=1 the controlRsp will have one expanded group, while the rsp will have multiple expanded groups. With default page size of 10, both the controlRsp and rsp will have four expanded groups so the tests pass. We can solve the test failures easily with a change to handleResults to remove groups that are not in the final docList. The distributed deep paging problem will continue to exist. The only way I see to resolve that problem is with the two pass model. distrib.singlePass is not the most efficient approach for every situation, so we can pick and choose when to apply it. [~shalinmangar], how does distrib.singlePass work with standard grouping? I suspect grouping still does multi-pass because it has a different distributed flow. > distrib.singlePass does not work for expand-request - start/rows included > ------------------------------------------------------------------------- > > Key: SOLR-6813 > URL: https://issues.apache.org/jira/browse/SOLR-6813 > Project: Solr > Issue Type: Bug > Components: multicore, search > Reporter: Per Steffensen > Assignee: Joel Bernstein > Labels: distributed_search, search > Attachments: test_that_reveals_the_problem.patch > > > Using distrib.singlePass does not work for expand-requests. Even after the > fix provided to SOLR-6812, it does not work for requests where you add start > and/or rows. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org