[ 
https://issues.apache.org/jira/browse/SOLR-6359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14249827#comment-14249827
 ] 

Forest Soup commented on SOLR-6359:
-----------------------------------

I applied the patch for SOLR-6359 on 4.7 and did some test. It does not work as 
expected. 
When I set below config, it still go into SnapPuller code even if I only newly 
added 800 doc.
<updateLog>
<str name="dir">$
{solr.ulog.dir:}
</str>
<int name="numRecordsToKeep">10000</int>
<int name="maxNumLogsToKeep">100</int>
</updateLog>
After my reading code, it seems that lines in 
org.apache.solr.update.PeerSync.handleVersions(ShardResponse srsp) cause the 
issue:
if (ourHighThreshold < otherLow)
{ // Small overlap between version windows and ours is older // This means that 
we might miss updates if we attempted to use this method. // Since there exists 
just one replica that is so much newer, we must // fail the sync. 
log.info(msg() + " Our versions are too old. 
ourHighThreshold="+ourHighThreshold + " otherLowThreshold="+otherLow); return 
false; }
Could you please comment? Thanks!

> Allow customization of the number of records and logs kept by UpdateLog
> -----------------------------------------------------------------------
>
>                 Key: SOLR-6359
>                 URL: https://issues.apache.org/jira/browse/SOLR-6359
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Ramkumar Aiyengar
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, Trunk
>
>
> Currently {{UpdateLog}} hardcodes the number of logs and records it keeps, 
> and the hardcoded numbers (100 records, 10 logs) can be quite low (esp. the 
> records) in an heavily indexing setup, leading to full recovery even if Solr 
> was just stopped and restarted.
> These values should be customizable (even if only present as expert options).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to