Robert Muir created LUCENE-6124: ----------------------------------- Summary: Fix broken close() methods Key: LUCENE-6124 URL: https://issues.apache.org/jira/browse/LUCENE-6124 Project: Lucene - Core Issue Type: Bug Reporter: Robert Muir
Closeable.close() says "If the stream is already closed then invoking this method has no effect.". But a lot of our code does not really respect that. If i add an "extra" close() call in assertingcodec, it finds all kinds of bugs in codec code, for example: {noformat} [junit4] Tests with failures (first 10 out of 59): [junit4] - org.apache.lucene.index.TestCrashCausesCorruptIndex.testCrashCorruptsIndexing [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsOnly [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositionsAndOffsetsAndPayloads [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqs [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositionsAndOffsets [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testRandom [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositionsAndPayloads [junit4] - org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositions [junit4] - org.apache.lucene.index.TestDirectoryReader.testFilesOpenClose [junit4] - org.apache.lucene.index.TestIndexWriterDelete.testIndexingThenDeleting {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org