[
https://issues.apache.org/jira/browse/LUCENE-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-6124:
--------------------------------
Attachment: LUCENE-6124.patch
Here is current patch, with those tests passing. BlockTree, NRTCachingDir,
MockDir, etc had bugs.
We need to add checks in e.g. BasePostingsFormatTestCase and all those kinds of
tests too, because I know there are other term dictionaries with the same
pattern blocktree has.
> Fix broken close() methods
> --------------------------
>
> Key: LUCENE-6124
> URL: https://issues.apache.org/jira/browse/LUCENE-6124
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Attachments: LUCENE-6124.patch, LUCENE-6124_asserts.patch,
> LUCENE-6124_asserts.patch
>
>
> Closeable.close() says "If the stream is already closed then invoking this
> method has no effect.".
> But a lot of our code does not really respect that. If i add an "extra"
> close() call in assertingcodec, it finds all kinds of bugs in codec code, for
> example:
> {noformat}
> [junit4] Tests with failures (first 10 out of 59):
> [junit4] -
> org.apache.lucene.index.TestCrashCausesCorruptIndex.testCrashCorruptsIndexing
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsOnly
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositionsAndOffsetsAndPayloads
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqs
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositionsAndOffsets
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testRandom
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositionsAndPayloads
> [junit4] -
> org.apache.lucene.codecs.asserting.TestAssertingPostingsFormat.testDocsAndFreqsAndPositions
> [junit4] - org.apache.lucene.index.TestDirectoryReader.testFilesOpenClose
> [junit4] -
> org.apache.lucene.index.TestIndexWriterDelete.testIndexingThenDeleting
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
