Hoss Man created SOLR-6869:
------------------------------

             Summary: need beter param sanity checking & error reporting in 
CoreAdmin API (and probably CollectionAdmin API)
                 Key: SOLR-6869
                 URL: https://issues.apache.org/jira/browse/SOLR-6869
             Project: Solr
          Issue Type: Bug
            Reporter: Hoss Man
            Priority: Minor


Today i made the mistake of doing this...

http://localhost:8983/solr/admin/cores?action=RELOAD&name=techproducts

...that request causes an NPE to be thrown by TreeMap.containsKey -- can you 
guess why?

... it's because i have the wrong param name (it should be 
{{core=techproducts}} ) and CoreAdminHandler.handleReloadAction doesn't bother 
to validate the input it gets  (or doesn't get in this case since "core" param 
is completely missing) before passing values on to lower level code.

we should audit all of the CoreAdminHandler API methods (and the 
CollectionAdminHandler methods) and make sure they return meaningful error 
messages if the mandatory request params are missing -- we can easily write 
tests that validate the expected error is thrown when various params are 
missing/bogus.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to