[
https://issues.apache.org/jira/browse/SOLR-5209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258367#comment-14258367
]
ASF GitHub Bot commented on SOLR-5209:
--------------------------------------
GitHub user cpoerschke opened a pull request:
https://github.com/apache/lucene-solr/pull/118
SOLR-5209: last replica removal no longer cascades to remove shard from
clusterstate
https://issues.apache.org/jira/i#browse/SOLR-5209
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/bloomberg/lucene-solr trunk-solr-5209
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/lucene-solr/pull/118.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #118
----
commit 90b1a394b50d4f456bfabab756cc64f28733e1a5
Author: Christine Poerschke <cpoersc...@bloomberg.net>
Date: 2014-12-24T12:07:56Z
SOLR-5209: last replica removal no longer cascades to remove shard from
clusterstate
old behaviour:
* last replica removal cascades to remove shard from clusterstate
* last shard removal cascades to remove collection from clusterstate
new behaviour:
* last replica removal preserves shard within clusterstate
* OverseerTest.testRemovalOfLastReplica added for replica removal logic
also:
* strings such as "collection1" and "state" in OverseerTest replaced with
variable or enum equvivalent
----
> cores/action=UNLOAD of last replica removes shard from clusterstate
> -------------------------------------------------------------------
>
> Key: SOLR-5209
> URL: https://issues.apache.org/jira/browse/SOLR-5209
> Project: Solr
> Issue Type: Bug
> Components: SolrCloud
> Affects Versions: 4.4
> Reporter: Christine Poerschke
> Assignee: Mark Miller
> Attachments: SOLR-5209.patch
>
>
> The problem we saw was that unloading of an only replica of a shard deleted
> that shard's info from the clusterstate. Once it was gone then there was no
> easy way to re-create the shard (other than dropping and re-creating the
> whole collection's state).
> This seems like a bug?
> Overseer.java around line 600 has a comment and commented out code:
> // TODO TODO TODO!!! if there are no replicas left for the slice, and the
> slice has no hash range, remove it
> // if (newReplicas.size() == 0 && slice.getRange() == null) {
> // if there are no replicas left for the slice remove it
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
