: > + public static final Set<String> EMPTY_STRING_SET =
Collections.emptySet();
: > +
:
: I don't know about this commit... i see a lot of EMPTY set's and maps
: defined statically here.
...
: I think we should be using the Collection methods, for example on your
: first file:
Hmmm... i am using the Collections method, it's the same set/map in each
case, i'm just creating static ref's to them with the type information.
My reading of the javadocs was that the implementation of emptySet() was
going to just return the same immutable instance every time anyway, so
there didn't seem to be any functional diff in reusing it like this -- it
seemed like the natureal way to migrate from using Collections.EMPTY_SET,
use our own local ref of the same object w/type info.
: - this(fieldName, fieldType, analyzer, EMPTY_STRING_SET);
: + this(fieldName, fieldType, analyzer, Collections.<String>emptySet());
Ah... see, i didn't even know that syntax was valid to bind the generic on
a static method. I'd only ever done the binding in the assignmet.
yeah, sure -- i'll make a note to myself to go back and clean those up.
-Hoss
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
