[ 
https://issues.apache.org/jira/browse/LUCENE-6145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14261235#comment-14261235
 ] 

Robert Muir commented on LUCENE-6145:
-------------------------------------

I am +1 to the patch, but not excited about permanently requiring the user to 
pass a MergePolicy to this collector.

One reason is that it makes it harder to integrate with other search code. E.G. 
somewhere i made a patch to allow inexact results/hit counts as flags to 
indexsearcher, which would make this collector much easier to use (and also 
allow other tricks). 

But this means somehow we have to serialize the "sort" better, which is 
complicated. So +1 to the patch for now :)

> Make EarlyTerminatingSortingCollector smarter about when it can early 
> terminate
> -------------------------------------------------------------------------------
>
>                 Key: LUCENE-6145
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6145
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6145.patch
>
>
> Today EarlyTerminatingSortingCollector only early-terminates if the sort 
> order matches exactly the index-time sort order. It should also 
> early-terminate when the sort order is a prefix of the index-time sort order.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to