[
https://issues.apache.org/jira/browse/SOLR-6496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14270996#comment-14270996
]
Steve Davids commented on SOLR-6496:
------------------------------------
The LB Client has duplicate implementations defined in both:
1. public Rsp request(Req req) throws SolrServerException, IOException
2. public NamedList<Object> request(final SolrRequest request) throws
SolrServerException, IOException
The original patch was only dealing with one of the two, we need to either a)
copy the same code into the other or b) refactor the methods to have a single
implementation that both methods call. Option B is my personal preference,
though we might want to just do that in a separate ticket and go with option A
to get it in as soon as possible. I can work on either tonight after I get back
from work if anyone has a route they would like to go.
> LBHttpSolrServer should stop server retries after the timeAllowed threshold
> is met
> ----------------------------------------------------------------------------------
>
> Key: SOLR-6496
> URL: https://issues.apache.org/jira/browse/SOLR-6496
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.9
> Reporter: Steve Davids
> Assignee: Anshum Gupta
> Priority: Critical
> Fix For: 5.0
>
> Attachments: SOLR-6496.patch, SOLR-6496.patch, SOLR-6496.patch,
> SOLR-6496.patch, SOLR-6496.patch
>
>
> The LBHttpSolrServer will continue to perform retries for each server it was
> given without honoring the timeAllowed request parameter. Once the threshold
> has been met, you should no longer perform retries and allow the exception to
> bubble up and allow the request to either error out or return partial results
> per the shards.tolerant request parameter.
> For a little more context on how this is can be extremely problematic please
> see the comment here:
> https://issues.apache.org/jira/browse/SOLR-5986?focusedCommentId=14100991&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14100991
> (#2)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
