[
https://issues.apache.org/jira/browse/SOLR-6902?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Erick Erickson updated SOLR-6902:
---------------------------------
Attachment: SOLR-6902.patch
Here's another version that removes a lot of the unused imports. I have to
confess I've just skimmed it, I'll take a closer look at the base classes
(where all the real action is) tomorrow.
I guess my question for everyone is what the consensus is here? My reservation
is mostly that this touches a _lot_ of files, and we're trying to cut 5.0 next
week. I'm reluctant to change this much code this close to setting the tag for
5.0. This seems more like style/cleanup than fixing outstanding problems, so
I'm thinking that waiting until the label is set for 5.0 and putting this in
5.1 might be the right thing to do here, assuming there are no objections.
Waiting will make resolving conflicts even more "interesting" since Alan is
going to be in the test code for removing old-style solr.xml....
That said, if some of the heavy cloud hitters (e.g. [~markrmil...@gmail.com]
[~romseygeek] and [~noble.paul]) think differently I'll be happy to commit
this after the precommit problem is fixed (see below).
The precommit target fails with:
/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java:87:
warning - @ShardsFixed(num is an unknown tag.
That's not a big deal though, I can ask someone who knows how to fix that where
to look. LuceneTestCase? Anyway, if we go forward we can fix that I'm sure.
BTW, I'm "Git challenged", and last time I tried to pull down a patch I somehow
got the wrong stuff, thanks for providing it! Generally we like to have the
patch rather than go to a repo so the JIRA is self-contained, we never know
when a repo will go away.
> Use JUnit rules instead of inheritance with distributed Solr tests to allow
> for multiple tests without the same class
> ---------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-6902
> URL: https://issues.apache.org/jira/browse/SOLR-6902
> Project: Solr
> Issue Type: Improvement
> Components: Tests
> Reporter: Ramkumar Aiyengar
> Priority: Minor
> Attachments: SOLR-6902.patch, SOLR-6902.patch
>
>
> Finally got annoyed enough with too many things being clubbed into one test
> method in all distributed Solr tests (anything inheriting from
> {{BaseDistributedSearchTestCase}} and currently implementing {{doTest}})..
> This just lays the groundwork really for allowing multiple test methods
> within the same class, and doesn't split tests as yet or flatten the
> inheritance hierarchy (when abused for doing multiple tests), as this touches
> a lot of files by itself. For that reason, the sooner this is picked up the
> better..
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
