[
https://issues.apache.org/jira/browse/LUCENE-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286949#comment-14286949
]
Robert Muir commented on LUCENE-6188:
-------------------------------------
Ramkumar: maybe it is the case. I just was responding to mike mccandless's
comment.
the sad facts are:
1. doclint only happens on trunk, as we need java8 to use it.
2. doclint currently does not validate html, i disabled that check, else builds
would fail. it was TooMuchToFixOverHolidayException.
3. doclint may not check all docs: package.html, overview.html, any other .html
we make via xslt
Currently the python code checks everything and is complete. it may be slow and
have some bugs but i think its not correct to remove it unless the replacement
is really a replacement.
> Remove HTML verification from checkJavaDocs.py
> ----------------------------------------------
>
> Key: LUCENE-6188
> URL: https://issues.apache.org/jira/browse/LUCENE-6188
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/javadocs
> Reporter: Ramkumar Aiyengar
> Assignee: Erick Erickson
> Priority: Minor
> Attachments: LUCENE-6188.patch, LUCENE-6188.patch
>
>
> Currently, the broken HTML verification in {{checkJavaDocs.py}} has issues in
> some cases (see SOLR-6902).
> On looking further to fix it with the {{html.parser}} package instead,
> noticed that there is broken HTML verification already present (using
> {{html.parser}}!)in {{checkJavadocLinks.py}} anyway which takes care of
> validation, and probably {{jTidy}} does it as well, going by the output
> (haven't verified it).
> Given this, the validation in {{checkJavaDocs.py}} doesn't seem to add any
> further value, so here's a patch to just nuke it instead.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
