[
https://issues.apache.org/jira/browse/SOLR-6851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288187#comment-14288187
]
Jan Høydahl commented on SOLR-6851:
-----------------------------------
Good stuff! Did some small typo fixes in the refguide chapter.
Have not run the install script yet, but here are some initial thoughts (not
criticism, just thoughts) :
* The script {{install_solr_service.sh}} installs Solr, not only a the
service/daemon scipt. Why not simply {{install_solr}}? We already have a
tradition to skip the .sh suffix on Linux, and shorter is better.
* Should the script reside on the top-level in the tarball, so extracting it is
simply {{tar xzf solr-5.0.0.tgz install_solr}}?
* If no args passed, and there are {{solr\-?\-?\-?.\[tgz|zip\]}} file(s) in
CWD, then we could assume the most recent one. Also would be nice that if no
args passed, enter interactive mode, unless {{-q}} (quiet) given
* Script should show help for {{\-h}} and {{--help}} as well, I always find it
weird with multi-char options after single dash
* Looks weird with {{/var/solr/data/data/...}} - could we simply choose
{{/var/solr/home}} for Solr home? Also, after completing SOLR-6671 we could
make data dir configurable and let it default to {{/var/solr/data}}
* If starting to adopt POSIX style locations, why not go all in and use
{{/etc/solr/}} for solr.solr.home, {{/var/solr/data}} for solr.data.home,
{{/var/run/solr/}} for PIDs and {{/var/log/solr/}} for logs? That's probably
where a random Unix sysadmin would look first
> Scripts to help install and run Solr as a service on Linux
> ----------------------------------------------------------
>
> Key: SOLR-6851
> URL: https://issues.apache.org/jira/browse/SOLR-6851
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Assignee: Timothy Potter
> Fix For: 5.0, Trunk
>
> Attachments: SOLR-6851.patch, SOLR-6851.patch, SOLR-6851.patch
>
>
> noticed 2 problems with the oom_solr.sh script...
> 1) the script is only being run with the port of hte solr instance to
> terminate, so the log messages aren't getting writen to the correct directory
> -- if we change hte script to take a log dir/file as an argument, we can
> ensure the logs are written to the correct place
> 2) on my ubuntu linux machine (where /bin/sh is a symlink to "/bin/dash"),
> the console log is recording a script error when java runs oom_solr.sh...
> {noformat}
> #
> # java.lang.OutOfMemoryError: Java heap space
> # -XX:OnOutOfMemoryError="/home/hossman/lucene/5x_dev/solr/bin/oom_solr.sh
> 8983"
> # Executing /bin/sh -c "/home/hossman/lucene/5x_dev/solr/bin/oom_solr.sh
> 8983"...
> /home/hossman/lucene/5x_dev/solr/bin/oom_solr.sh: 20: [: 14305: unexpected
> operator
> Running OOM killer script for process 14305 for Solr on port 8983
> Killed process 14305
> {noformat}
> steps to reproduce: {{bin/solr -e techproducts -m 10m}}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
