[ https://issues.apache.org/jira/browse/LUCENE-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Simon Willnauer updated LUCENE-2865: ------------------------------------ Attachment: LUCENE-2865.patch bq. I would make the ctor private and then use ScorerContext.default().x().y() as pattern (default returns the template). I like this design more Jawohl! :) - Since default is a keyword in java I used ScorerContext#def() instead. I fixed some JDoc issues, made all ScorerContext ctors private and added a changes.txt entry seems like we are good to go > Pass a context struct to Weight#scorer instead of naked booleans > ---------------------------------------------------------------- > > Key: LUCENE-2865 > URL: https://issues.apache.org/jira/browse/LUCENE-2865 > Project: Lucene - Java > Issue Type: Improvement > Components: Search > Affects Versions: 4.0 > Reporter: Simon Willnauer > Assignee: Simon Willnauer > Fix For: 4.0 > > Attachments: LUCENE-2865.patch, LUCENE-2865.patch > > > Weight#scorer(AtomicReaderContext, boolean, boolean) is hard to extend if > another boolean like "needsScoring" or similar flags / information need to be > passed to Scorers. An immutable struct would make such an extension trivial / > way easier. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online. --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org