[ 
https://issues.apache.org/jira/browse/SOLR-4586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14298703#comment-14298703
 ] 

Shawn Heisey commented on SOLR-4586:
------------------------------------

bq. Instead of eliminating the limit on the Solr side, which Rob insists on 
wielding is veto power to block, I propose here a low value

I like this idea, despite the pain I *know* it will cause.  Most people who 
have existing configs based on the example will already have a config that sets 
the value to 1024, so the pain will be mostly felt by new users ... but it will 
be felt early enough that they will probably have it fixed before they deploy 
to production.

bq. My technical veto still stands as a member of the PMC.  It does not matter 
who i work for.

I'm aware of the rights that Apache gives you, but just because you have the 
power doesn't mean you must use it.

----

If eliminating the limit isn't going to happen, then I have the following 
proposal, in addition to lowering the default to 64.  I think I built this idea 
into some of the patch work I did for this issue, but I can no longer remember 
for sure:  I propose that we include code so that the *highest* 
maxBooleanClauses value seen during core loading become the global value, 
preventing a lower value seen later during the load process from overriding it.


> Eliminate the maxBooleanClauses limit
> -------------------------------------
>
>                 Key: SOLR-4586
>                 URL: https://issues.apache.org/jira/browse/SOLR-4586
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 4.2
>         Environment: 4.3-SNAPSHOT 1456767M - ncindex - 2013-03-15 13:11:50
>            Reporter: Shawn Heisey
>         Attachments: SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586.patch, SOLR-4586.patch, SOLR-4586.patch, 
> SOLR-4586_verify_maxClauses.patch
>
>
> In the #solr IRC channel, I mentioned the maxBooleanClauses limitation to 
> someone asking a question about queries.  Mark Miller told me that 
> maxBooleanClauses no longer applies, that the limitation was removed from 
> Lucene sometime in the 3.x series.  The config still shows up in the example 
> even in the just-released 4.2.
> Checking through the source code, I found that the config option is parsed 
> and the value stored in objects, but does not actually seem to be used by 
> anything.  I removed every trace of it that I could find, and all tests still 
> pass.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to