[ https://issues.apache.org/jira/browse/LUCENE-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301651#comment-14301651 ]
Uwe Schindler commented on LUCENE-6213: --------------------------------------- [~jpountz]: Why is the list of unsupported codecs an Array. A simple unmodifiable set would be better, would spare lots of code :-) If its a singletonSet its even simpler :-) Otherwise use {{Collections.unmodifiableSet(new HashSet<>(Arrays.asList(codecs)))}}. You don't need to change that, but to me this looks simplier and more correct. Memory usage or speed is not a problem here, it is static and never changes after class init. > Add test for IndexFormatTooOldException if a commit has a 3.x segment > --------------------------------------------------------------------- > > Key: LUCENE-6213 > URL: https://issues.apache.org/jira/browse/LUCENE-6213 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Assignee: Ryan Ernst > Attachments: LUCENE-6213.patch, LUCENE-6213.patch, LUCENE-6213.patch, > unsupported.4x-with-3x-segments.zip > > > We should add a 4.x index (4.x commit) with some 3.x segment(s) to our > backwards tests. > I don't think we throw IndexFormatTooOldException correctly in this case. I > think instead the user will get a confusing SPI error about a missing codec > "Lucene3x". -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org