[ 
https://issues.apache.org/jira/browse/LUCENE-2867?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982237#action_12982237
 ] 

Simon Willnauer commented on LUCENE-2867:
-----------------------------------------

bq. Thanks for reviewing the patch Simon!

you are welcome... I saw your commit and I wonder why you committed into 
branches/branch_3x but not in trunk first and then backport? Usually we put 
changes into trunk first and then move them to the branches though. Now this 
issues has been closed / resolved and it has not been committed to trunk and 
neither to 3.0.4 as stated in the FixVersion? Now I am confused...

So 4.0 changes go into trunk:
http://svn.apache.org/repos/asf/lucene/dev/trunk/

Changes for 3.x go here
http://svn.apache.org/repos/asf/lucene/dev/branches/branch_3x/

And eventually you deprecations can go here to be in 3.0.4 if that gets 
released at all...
http://svn.apache.org/repos/asf/lucene/java/branches/lucene_3_0/

and / or here:

http://svn.apache.org/repos/asf/lucene/java/branches/lucene_2_9/

does that make sense?

> Change contrib QP API that uses CharSequence as string identifier
> -----------------------------------------------------------------
>
>                 Key: LUCENE-2867
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2867
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/*
>    Affects Versions: 3.0.3
>            Reporter: Adriano Crestani
>            Assignee: Adriano Crestani
>            Priority: Minor
>             Fix For: 3.0.4
>
>         Attachments: lucene_2867_adriano_crestani_2011_01_13.patch
>
>
> There are some API methods on contrib queryparser that expects CharSequence 
> as identifier. This is wrong, since it may lead to incorrect or mislead 
> behavior, as shown on LUCENE-2855. To avoid this problem, these APIs will be 
> changed and enforce the use of String instead of CharSequence on version 4. 
> This patch already deprecate the old API methods and add new substitute 
> methods that uses only String.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to