[
https://issues.apache.org/jira/browse/SOLR-6920?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14309788#comment-14309788
]
Mark Miller commented on SOLR-6920:
-----------------------------------
bq. 3
I'm not following - what are you seeing exactly? I read it as 'if a file was
not checksummed, download anyway if it matches this file list'.
bq. || (!compareResult.checkSummed && (((String)
file.get(NAME)).endsWith(".si") || ((String) file.get(NAME)).endsWith(".liv")
|| ((String) file.get(NAME)).startsWith("segments_")))
If the file is checksummed, we can rely on the checksum. What am I missing that
you are seeing?
> During replication use checksums to verify if files are the same
> ----------------------------------------------------------------
>
> Key: SOLR-6920
> URL: https://issues.apache.org/jira/browse/SOLR-6920
> Project: Solr
> Issue Type: Bug
> Components: replication (java)
> Reporter: Varun Thacker
> Assignee: Mark Miller
> Priority: Critical
> Attachments: SOLR-6920.patch, SOLR-6920.patch, SOLR-6920.patch,
> SOLR-6920.patch, SOLR-6920.patch, SOLR-6920.patch
>
>
> Currently we check if an index file on the master and slave is the same by
> checking if it's name and file length match.
> With LUCENE-2446 we now have a checksums for each index file in the segment.
> We should leverage this to verify if two files are the same.
> Places like SnapPuller.isIndexStale and SnapPuller.downloadIndexFiles should
> check against the checksum also.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
