[ 
https://issues.apache.org/jira/browse/LUCENE-6239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317859#comment-14317859
 ] 

Dawid Weiss commented on LUCENE-6239:
-------------------------------------

Ah, sorry -- I read the patch but missed this part:
{code}
+          try {
+            final Object vmOption = getVMOptionMethod.invoke(hotSpotBean, 
"ObjectAlignmentInBytes");
+            objectAlignment = Integer.parseInt(
+                
vmOption.getClass().getMethod("getValue").invoke(vmOption).toString()
+            );
+          } catch (ReflectiveOperationException | IllegalArgumentException | 
SecurityException e) {
+            // ignore
+          }
{code}

I'm fine with these changes, really. Thanks for exploring the alternatives, Uwe.

> Remove RAMUsageEstimator Unsafe calls
> -------------------------------------
>
>                 Key: LUCENE-6239
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6239
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Robert Muir
>         Attachments: LUCENE-6239.patch, LUCENE-6239.patch
>
>
> This is unnecessary risk. We should remove this stuff, it is not needed here. 
> We are a search engine, not a ram calculator.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to