[
https://issues.apache.org/jira/browse/SOLR-7043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14319019#comment-14319019
]
Jan Høydahl commented on SOLR-7043:
-----------------------------------
The bin/solr shell/batch script only needs to locate (any) JAVA to start
SolrCLI, and that logic is already in place. The SolrCLI process itself do not
need all the JVM flags etc, as its only job would be to parse cmdline opts and
config, then assemble the complete solr command line and return it to the
script for execution (to avoid another child process).
> Refactor SolrCLI, bin\solr, bin\solr.cmd to be more unit-testable and less OS
> specific
> --------------------------------------------------------------------------------------
>
> Key: SOLR-7043
> URL: https://issues.apache.org/jira/browse/SOLR-7043
> Project: Solr
> Issue Type: Improvement
> Components: scripts and tools
> Reporter: Timothy Potter
> Assignee: Timothy Potter
>
> With the 5.0 release, we've reached critical mass with the bin/solr script
> interface, but we've picked up some cruft along the way. Specifically,
> there's too much OS-specific constructs in the scripts and they are quite
> complex overall. They also require extensive manual testing. Moreover,
> SolrCLI (provides support for the scripts) needs to be refactored to use the
> Collections API support added to SolrJ instead of using low-level JSON / HTTP
> constructs. SolrCLI is also in desperate need of a unit test. The overall
> goal of this ticket is to move as much as possible out of the shell scripts
> and into SolrCLI, thus increasing test coverage.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
