[ 
https://issues.apache.org/jira/browse/SOLR-6917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321965#comment-14321965
 ] 

Shalin Shekhar Mangar commented on SOLR-6917:
---------------------------------------------

bq. I'm not sure we should do this. The most common usecase is that somebody 
just gave a wrong name and it is genuinely not there. It actually does all this 
work for all requests.

Sorry, I incorrectly described the change. Look at the patch that I posted for 
details. It doesn't actually make requests to all the shards but only tries to 
select an active replica looking at all shards.

But now that you raised this question, this logic of selecting a shard is 
itself wrong -- the jar will be in exactly one shard and we should find the 
right shard and go to it directly. This indirection isn't saving us anything 
except when numShards=1.

> TestDynamicLoading fails frequently.
> ------------------------------------
>
>                 Key: SOLR-6917
>                 URL: https://issues.apache.org/jira/browse/SOLR-6917
>             Project: Solr
>          Issue Type: Test
>            Reporter: Mark Miller
>            Assignee: Noble Paul
>            Priority: Minor
>         Attachments: SOLR-6917.patch
>
>
> most recent failure:
> {noformat}
>    [junit4] FAILURE 39.7s J5 | TestDynamicLoading.testDistribSearch <<<
>    [junit4]    > Throwable #1: java.lang.AssertionError: New version of class 
> is not loaded {
>    [junit4]    >   "responseHeader":{
>    [junit4]    >     "status":404,
>    [junit4]    >     "QTime":2},
>    [junit4]    >   "error":{
>    [junit4]    >     "msg":"no such blob or version available: test/2",
>    [junit4]    >     "code":404}}
>    [junit4]    >      at 
> __randomizedtesting.SeedInfo.seed([B49634A982DC7AFE:3570BAB1F5831AC2]:0)
>    [junit4]    >      at 
> org.apache.solr.core.TestDynamicLoading.dynamicLoading(TestDynamicLoading.java:154)
>    [junit4]    >      at 
> org.apache.solr.core.TestDynamicLoading.doTest(TestDynamicLoading.java:64)
>    [junit4]    >      at 
> org.apache.solr.BaseDistributedSearchTestCase.testDistribSearch(BaseDistributedSearchTestCase.java:868)
>    [junit4]    >      at java.lang.Thread.run(Thread.java:745)
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to