[ 
https://issues.apache.org/jira/browse/SOLR-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12982740#action_12982740
 ] 

Robert Muir commented on SOLR-1674:
-----------------------------------

i'd still like to add posinc tests for some of these tokenstreams,
but also other ones in the analyzers module too (e.g. ones from lucene contrib).

i'll set 3.2 for now.

> improve analysis tests, cut over to new API
> -------------------------------------------
>
>                 Key: SOLR-1674
>                 URL: https://issues.apache.org/jira/browse/SOLR-1674
>             Project: Solr
>          Issue Type: Test
>          Components: Schema and Analysis
>            Reporter: Robert Muir
>            Assignee: Mark Miller
>             Fix For: 4.0
>
>         Attachments: SOLR-1674.patch, SOLR-1674.patch, SOLR-1674_speedup.patch
>
>
> This patch
> * converts all analysis tests to use the new tokenstream api
> * converts most tests to use the more stringent assertion mechanisms from 
> lucene
> * adds new tests to improve coverage
> Most bugs found by more stringent testing have been fixed, with the exception 
> of SynonymFilter.
> The problems with this filter are more serious, the previous tests were 
> essentially a no-op.
> The new tests for SynonymFilter test the current behavior, but have FIXMEs 
> with what I think the old test wanted to expect in the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to