[
https://issues.apache.org/jira/browse/SOLR-7110?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14323145#comment-14323145
]
Yonik Seeley commented on SOLR-7110:
------------------------------------
It's not clear what's what here... did the test take 668ms without the patch
and 709ms with the patch?
Measuring memory isn't enough here... GC is very efficient at cleaning up short
lived objects, and the only downside to letting GC do it is some CPU time,
which should show up in a throughput benchmark if this is a win.
> Optimize JavaBinCodec to minimize string Object creation
> --------------------------------------------------------
>
> Key: SOLR-7110
> URL: https://issues.apache.org/jira/browse/SOLR-7110
> Project: Solr
> Issue Type: Improvement
> Reporter: Noble Paul
> Assignee: Noble Paul
> Priority: Minor
> Attachments: SOLR-7110.patch
>
>
> In JavabinCodec we already optimize on strings creation , if they are
> repeated in the same payload. if we use a cache it is possible to avoid
> string creation across objects as well.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
