[ 
https://issues.apache.org/jira/browse/SOLR-7118?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14326233#comment-14326233
 ] 

Shalin Shekhar Mangar commented on SOLR-7118:
---------------------------------------------

{quote}
The point of that failure is to alert us that we are seeing more failures than 
before. It's an arbitrary threshold that at one time was enough to cover the 
failures we see.

We don't want that test to keep passing when all of sudden 90% of the updates 
fail. We want to know why all of a sudden there are more failures. If it's 
reasonable why things changed (is it?), then the threshold can be raised.
{quote}

No, I totally get why the test is written like that. The failures due to the 
full throttle test do not count towards the indexing failures so I don't see 
why things should have changed. I'll add this issue number to the failure 
message for easier tracking.

I'd love to find a better way to test this, though I can't think of one right 
now. Chasing such false negatives wastes too much time and energy.

> ChaosMonkeyNothingIsSafeTest fails with too many update fails
> -------------------------------------------------------------
>
>                 Key: SOLR-7118
>                 URL: https://issues.apache.org/jira/browse/SOLR-7118
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrCloud, Tests
>    Affects Versions: 5.0
>            Reporter: Shalin Shekhar Mangar
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-7118.patch
>
>
> There are frequent failures on both trunk and branch_5x with the following 
> message:
> {code}
> java.lang.AssertionError: There were too many update fails - we expect it can 
> happen, but shouldn't easily
>       at 
> __randomizedtesting.SeedInfo.seed([786DB0FD42626C16:F98B3EE5353D0C2A]:0)
>       at org.junit.Assert.fail(Assert.java:93)
>       at org.junit.Assert.assertTrue(Assert.java:43)
>       at org.junit.Assert.assertFalse(Assert.java:68)
>       at 
> org.apache.solr.cloud.ChaosMonkeyNothingIsSafeTest.doTest(ChaosMonkeyNothingIsSafeTest.java:224)
>       at 
> org.apache.solr.BaseDistributedSearchTestCase.testDistribSearch(BaseDistributedSearchTestCase.java:878)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to