[ 
https://issues.apache.org/jira/browse/LUCENE-6261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Adrien Grand updated LUCENE-6261:
---------------------------------
    Attachment: LUCENE-6261.patch

Simple patch that adds assertions to RandomApproximationQuery, which is used in 
the approximation equivalence tests.

> TwoPhaseDocIdSetIterator.matches should be called at most once per doc ID
> -------------------------------------------------------------------------
>
>                 Key: LUCENE-6261
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6261
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Adrien Grand
>            Assignee: Adrien Grand
>            Priority: Minor
>         Attachments: LUCENE-6261.patch
>
>
> We did not document it but TwoPhaseDocIdSetIterator.matches should only be 
> called once per doc ID. In some cases, running it twice might not work (eg. 
> phrases since the positions would already be consumed when we try to call 
> matches() on the second time) and in the general case it would be a 
> performance bug if this method is called several times anyway.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to