[
https://issues.apache.org/jira/browse/SOLR-7127?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333316#comment-14333316
]
Steve Molloy commented on SOLR-7127:
------------------------------------
bq. How about instead of returning a vanilla SolrClient, we return a
CollectionSolrClient, which is an extension of CloudSolrClient with all the
setters overridden to throw UnsupportedOperationException. That also makes it
easier to track whether or not we should close resources, etc.
I think it would be better to extend SolrClient and expose methods that make
sense instead of CloudSolrClient and having a bunch of methods that simply
throw exceptions. I like the idea of having a CollectionSolrClient (or whatever
other name that makes sense), but exposing a bunch of methods simply throwing
exceptions is counter-intuitive for people using the API.
> Add method to CloudSolrClient to create per-collection clients
> --------------------------------------------------------------
>
> Key: SOLR-7127
> URL: https://issues.apache.org/jira/browse/SOLR-7127
> Project: Solr
> Issue Type: Improvement
> Reporter: Alan Woodward
> Assignee: Alan Woodward
> Priority: Minor
> Attachments: SOLR-7127.patch, SOLR-7127.patch
>
>
> CloudSolrClient isn't thread-safe if you're making requests to multiple
> collections, because defaultCollection is mutable. This can be a pain if
> you're trying to index into multiple collections from a single queue of
> documents.
> This issue adds a .getCollectionClient(String) method to CloudSolrClient that
> returns a child client directed at that collection. Under the hood it's
> another CloudSolrClient sharing it's resources with the parent client, but
> with a separate default collection set. The method returns a SolrClient,
> however, so you can't then change the collection unless you explicitly cast
> it.
> Sort of related to what I wanted to do on SOLR-6894, but this is more
> focussed.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
