[ 
https://issues.apache.org/jira/browse/SOLR-7151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14334980#comment-14334980
 ] 

Alan Woodward commented on SOLR-7151:
-------------------------------------

bq. We are great about http, but anything java is a mine field. And soon we 
would like to support rolling upgrades to some degree.

Agreed!  I don't think this will effect rolling upgrades, though?  This just 
changes how the client handles exceptions - you can still talk to a 5.1 server 
using a 4.10 client, and vice versa.

> SolrClient.query() methods should throw IOException
> ---------------------------------------------------
>
>                 Key: SOLR-7151
>                 URL: https://issues.apache.org/jira/browse/SOLR-7151
>             Project: Solr
>          Issue Type: Bug
>          Components: SolrJ
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>            Priority: Minor
>             Fix For: Trunk, 5.1
>
>         Attachments: SOLR-7151.patch
>
>
> All the methods on SolrClient are declared as throwing SolrServerException 
> (thrown if there's an error somewhere on the server), and IOException (thrown 
> if there's a communication error), except for the QueryRequest methods.  
> These swallow up IOException and repackage them in a SolrServerException.
> I think these are useful distinctions to make (you might want to retry on an 
> IOException, but not on a SolrServerException), and we should make the query 
> methods fall in line with the others.
> I'm not sure if this should go into 5.x as well as trunk, as it's a 
> backwards-breaking change.  I'm leaning towards yes, as it's a sufficiently 
> useful API change that it's worth the break, but I'm not going to insist on 
> it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to