[ 
https://issues.apache.org/jira/browse/LUCENE-6299?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Robert Muir updated LUCENE-6299:
--------------------------------
    Attachment: LUCENE-6299_addIndexes.patch

Here is a patch for addIndexes.
we return an error before we do any copying, and don't allow any overflows.

The test is kinda evil in the way it cheats, but its fast and does the job.

disk full testing in general was broken for addIndexes in case of FSDir, 
because MockDir would delegate optional copyBytes method directly, and not 
count those bytes. Instead this mess of optional methods is cleaned up, so that 
MockDir checks everything, but when we run tests with the "raw" dir, we 
delegate everything directly to it (except close, for checkindex).



> IndexWriter's enforcement of 2.1B doc limits is buggy
> -----------------------------------------------------
>
>                 Key: LUCENE-6299
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6299
>             Project: Lucene - Core
>          Issue Type: Bug
>            Reporter: Michael McCandless
>            Assignee: Michael McCandless
>         Attachments: LUCENE-6299_addIndexes.patch
>
>
> E.g. if you pass an already > 2.1B docs to either addIndexes, it can fail to 
> enforce properly.
> IW's private reserveDocs should refuse to accept negative values.
> IW.deleteAll fails to set the pendingNumDocs to 0.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to