[
https://issues.apache.org/jira/browse/SOLR-7171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14341799#comment-14341799
]
Alan Woodward commented on SOLR-7171:
-------------------------------------
Oh God, I spent days trying to refactor this before I gave up and used the
hacky "just create a damn core.properties file" solution. The issue with
SOLR-6840 was that there were a bunch of solr.xml files that defined a core
called collection1, and the tests assumed that this core would exist when they
started. But the new format doesn't allow for that, so the tests now had to
create core.properties files instead.
Anyway, your fix looks good Hoss. I like that it makes it explicit that it's
creating a new solr.xml and empty core.
> BaseDistributedSearchTestCase.getSolrXml() not used consistently - multiple
> divergent ways a JettySolrRunner may be inited
> --------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-7171
> URL: https://issues.apache.org/jira/browse/SOLR-7171
> Project: Solr
> Issue Type: Bug
> Reporter: Hoss Man
> Attachments: SOLR-7171.patch, SOLR-7171.patch
>
>
> As part of SOLR-6349, i wanted to take advantage of the new features in
> SOLR-7147 to inspect shard requests in TestDistributedSearch, but even though
> i added a proper override of getSolrXml...
> {code}
> @Override
> protected String getSolrXml() {
> return "solr-trackingshardhandler.xml";
> }
> {code}
> ...that value was being ignored, and i was never getting an instance of
> TrackingShardHandlerFactory.
> I poked around a bit and confirmed that getSolrXml() is used by
> "setupJettySolrHome(File)" but that method is never called by
> BaseDistributedSearchTestCase - it's only called in framework subclasses like
> AbstractDistribZkTestBase and AbstractFullDistribZkTestBase. Instead, for
> simple subclasses of BaseDistributedSearchTestCase the jetty instances seem
> to be coming from createServers(int)
> ----
> I don't really understand why there are so many diff ways for a shard
> instance to be inited, and presumably that should be refactored? .. but a
> more immediate concern is that subclasses of BaseDistributedSearchTestCase
> which attempt to override the solr.xml file used can't (unless they are
> actually a subclass of AbstractDistribZkTestBase of
> AbstractFullDistribZkTestBase)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
