[ https://issues.apache.org/jira/browse/SOLR-7179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14344911#comment-14344911 ]
Alan Woodward commented on SOLR-7179: ------------------------------------- Still chasing down some errors due to various tests setting coreRootDirectory in system properties. Will hopefully be able to commit this in the next couple of days though. > JettySolrRunner should not use system properties to pass configuration > ---------------------------------------------------------------------- > > Key: SOLR-7179 > URL: https://issues.apache.org/jira/browse/SOLR-7179 > Project: Solr > Issue Type: Improvement > Reporter: Alan Woodward > Assignee: Alan Woodward > Priority: Minor > Attachments: SOLR-7179.patch, SOLR-7179.patch > > > JettySolrRunner sets a bunch of system properties to pass configuration down > to its SolrDispatchFilter and CoreContainer. This means that we can't launch > multiple runners at the same time - sys props must be set up, the runner > launched, we wait for solr to start up, then sys props must be changed before > the next runner can be instantiated. > Instead we should be able to pass the relevant properties down to > SolrDispatchFilter via the servlet context. This will allow > MiniSolrCloudCluster and the various ZK test cases to start and stop their > jetties in parallel, which will speed up individual tests (and with luck > speed up the test suite overall as well). -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org