[ 
https://issues.apache.org/jira/browse/LUCENE-6304?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14345707#comment-14345707
 ] 

Robert Muir commented on LUCENE-6304:
-------------------------------------

Thanks Lee, I like this.

When i see code overriding hashcode/equals and not calling 
super.hashcode/super.equals, its a bad sign. 

We should commit this one, and remove duplicated logic and hardcoded constants 
in e.g. TermQuery and all other places in a followup. 

> Add MatchNoDocsQuery that matches no documents
> ----------------------------------------------
>
>                 Key: LUCENE-6304
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6304
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/search
>    Affects Versions: 5.0
>            Reporter: Lee Hinman
>            Priority: Minor
>         Attachments: LUCENE-6304.patch, LUCENE-6304.patch, LUCENE-6304.patch, 
> LUCENE-6304.patch
>
>
> As a followup to LUCENE-6298, it would be nice to have an explicit 
> MatchNoDocsQuery to indicate that no documents should be matched. This would 
> hopefully be a better indicator than a BooleanQuery with no clauses or (even 
> worse) null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to