[ https://issues.apache.org/jira/browse/SOLR-6724?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Greg Solovyev updated SOLR-6724: -------------------------------- Attachment: SOLR-6724.patch A straightforward patch moving retries logic from createMethod to executeMethod and a unit test to confirm that it works > HttpServer maxRetries attributes seems like not being used as expected > ---------------------------------------------------------------------- > > Key: SOLR-6724 > URL: https://issues.apache.org/jira/browse/SOLR-6724 > Project: Solr > Issue Type: Bug > Components: clients - java > Affects Versions: 4.10.2 > Environment: OS X 10.9.5 > Java 1.7.0_60 > Reporter: Márcio Furlani Carmona > Priority: Minor > Attachments: SOLR-6724.patch > > > Looks like maxRetries is being misused in the > org.apache.solr.client.solrj.impl.HttpSolrServer.createMethod(SolrRequest) > instead of being used in the executeMethod(HttpRequestBase,ResponseParser). > In the current implementation the maxRetries is used in a loop that only > instantiates the HttpRequestBase but it doesn't effectively make any HTTP > request. Also the retries are made even in a successful instantiation of the > HttpRequestBase as there's no break too. > I notice there's also a catch for NoHttpResponseException but as no HTTP > request is made I guess it will never happen. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org