[ 
https://issues.apache.org/jira/browse/LUCENE-6354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mikhail Khludnev updated LUCENE-6354:
-------------------------------------
    Attachment: LUCENE-6354.patch

I added a primitive test into the patch. 
[~martijn.v.groningen] you are right, but it makes me worry, because such 
conditional logic 

bq. Also if just the ToParentBlockJoinQuery is used in a search then the 
TwoPhaseIterator isn't used.

 is not obvious to me. 

[~jpountz] isn't it a way convenient to make TwoPhaseIterator flow work always 
i.e. make it mandatory? 
in this case I don't need ugly wrapper in my test (it's not a proposal, but 
just a workaround, to enforce TwoPhaseIterator magic)

{code}
s.search(
        // I wonder why not just bjq?
        new FilteredQuery( bjq, 
parentsFilter,FilteredQuery.LEAP_FROG_QUERY_FIRST_STRATEGY)
    , expect.size()*2+1);
{code} 

> Add minChildren and maxChildren options to ToParentBlockJoinQuery
> -----------------------------------------------------------------
>
>                 Key: LUCENE-6354
>                 URL: https://issues.apache.org/jira/browse/LUCENE-6354
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-6354.patch, LUCENE-6354.patch, LUCENE-6354.patch
>
>
> This effectively allows to ignore parent documents with too few children 
> documents via the minChildren option or too many matching children documents 
> via the maxChildren option. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to