[ https://issues.apache.org/jira/browse/SOLR-6682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14355086#comment-14355086 ]
ASF subversion and git services commented on SOLR-6682: ------------------------------------------------------- Commit 1665579 from hoss...@apache.org in branch 'dev/trunk' [ https://svn.apache.org/r1665579 ] SOLR-6349 + SOLR-6682: Added support for stats.field localparams to enable/disable individual stats; Fix response when using EnumField with StatsComponent > EnumField + StatsComponent gives bad toString() for min/max, probably doesn't > work in distributed search ... definitely needs more tests > ---------------------------------------------------------------------------------------------------------------------------------------- > > Key: SOLR-6682 > URL: https://issues.apache.org/jira/browse/SOLR-6682 > Project: Solr > Issue Type: Bug > Reporter: Hoss Man > Attachments: SOLR-6682.patch, SOLR-6682.patch > > > when EnumField was added, support was included in StatsComponent for it (via > the EnumStatsValues) but it doesn't seem to have ever had any tests written > for it. > doing some quick manual testing, it seems like the min/max values just wind > up being the "toString()" value of the EnumFieldValue, so you get a response > like this... > {code} > <lst name="stats"> > <lst name="stats_fields"> > <lst name="hoss"> > <str name="min">org.apache.solr.common.EnumFieldValue:Low</str> > <str name="max">org.apache.solr.common.EnumFieldValue:High</str> > <long name="count">2</long> > <long name="missing">0</long> > <lst name="facets"/></lst> > </lst> > </lst> > {code} > we should fix this to return just the stat label, and update the various > StatsComponent tests to also cover enums & make sure it works as well as > strings & numbers. > notably: i'm fairly certain this EnumStatsValues class won't work at all in a > distributed (stats) request. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org