[
https://issues.apache.org/jira/browse/LUCENE-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984206#action_12984206
]
Shay Banon commented on LUCENE-2871:
------------------------------------
bq. Looking at the current patch, the class seems wrong. In my opinion, this
should be only in NIOFSDirectory. SimpleFSDir should only use RAF.
Its a good question, not sure what to do with it. Here is the problem. The
channel output can be used with all 3 FS dirs (simple, nio, and mmap), and
actually might make sense to be used even with SimpleFS (i.e. using non nio to
read, but use file channel to write). In order to have all of them supported,
currently, the simplest way is to put it in the base class so code will be
shared. On IRC, a discussion was made to externalize the outputs and inputs,
and then one can more easily pick and choose, but I think this will belong on a
different patch.
> Use FileChannel in FSDirectory
> ------------------------------
>
> Key: LUCENE-2871
> URL: https://issues.apache.org/jira/browse/LUCENE-2871
> Project: Lucene - Java
> Issue Type: New Feature
> Components: Store
> Reporter: Shay Banon
> Attachments: LUCENE-2871.patch, LUCENE-2871.patch
>
>
> Explore using FileChannel in FSDirectory to see if it improves write
> operations performance
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
