[
https://issues.apache.org/jira/browse/LUCENE-2474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12984280#action_12984280
]
Michael McCandless commented on LUCENE-2474:
--------------------------------------------
bq. Actually, I am against the last patch you posted, as it clearly has nothing
to do with this issue
Woops! Heh.
bq. A MultiReader is just a wrapper - you don't reopen it, so it could just
start off with an empty listener list, the subs could all retain their listener
lists and an addListener() could just delegate to the contained readers.
Well, it does have a reopen (reopens the subs & wraps in a new MR), but I guess
delegation would work for MR. And, same for ParallelReader.
And I think the NRT case should work fine, since we don't expose IW.getReader
anymore (hmm -- this was never backported to 3.x?) -- if you new
IndexReader(IW), it creates a single collection holding all listeners, and then
shares it w/ all SRs.
> Allow to plug in a Cache Eviction Listener to IndexReader to eagerly clean
> custom caches that use the IndexReader (getFieldCacheKey)
> ------------------------------------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2474
> URL: https://issues.apache.org/jira/browse/LUCENE-2474
> Project: Lucene - Java
> Issue Type: Improvement
> Components: Search
> Reporter: Shay Banon
> Fix For: 3.1, 4.0
>
> Attachments: LUCENE-2474.patch, LUCENE-2474.patch, LUCENE-2574.patch
>
>
> Allow to plug in a Cache Eviction Listener to IndexReader to eagerly clean
> custom caches that use the IndexReader (getFieldCacheKey).
> A spin of: https://issues.apache.org/jira/browse/LUCENE-2468. Basically, its
> make a lot of sense to cache things based on IndexReader#getFieldCacheKey,
> even Lucene itself uses it, for example, with the CachingWrapperFilter.
> FieldCache enjoys being called explicitly to purge its cache when possible
> (which is tricky to know from the "outside", especially when using NRT -
> reader attack of the clones).
> The provided patch allows to plug a CacheEvictionListener which will be
> called when the cache should be purged for an IndexReader.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
